Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up soon to be stable features and enabled lints #705

Merged
merged 1 commit into from
May 6, 2024

Conversation

udoprog
Copy link
Collaborator

@udoprog udoprog commented May 6, 2024

Allowing unexpected_cfgs since there is no apparent way to fix it without introducing a build script.

Relates: rust-lang/cargo#13571

@udoprog udoprog added the enhancement New feature or request label May 6, 2024
@udoprog udoprog merged commit a5e112e into main May 6, 2024
21 checks passed
@udoprog udoprog deleted the new-features-lints branch May 6, 2024 18:55
@Urgau
Copy link

Urgau commented May 24, 2024

Heads up, with the release of rust-lang/cargo#13913 (in nightly-2024-05-19), there is no longer any need for the kind of workarounds employed in this PR. Cargo has now gain the ability to declare --check-cfg args directly inside the [lints] table with [lints.rust.unexpected_cfgs.check-cfg]1:

Cargo.toml:

[lints.rust]
unexpected_cfgs = { level = "warn", check-cfg = ['cfg(foo)'] }

Note that the diagnostic output of the lint has been updated to suggest the [lints] approach first. You can use it to guide you through the --check-cfg arguments that may need to be added.

Footnotes

  1. take effect on Rust 1.80 (current nightly), is ignored on Rust 1.79 (current beta), and produce an unused warning below

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants